[U-Boot-Users] [PATCH 1/2] add Kendein/Micrel KS8695P CPU support

[Wolfgang Denk]

Dear Greg,

in message <r02010500-1041-5A1EF226C91011D9BF6200039387ACB6@[10.0.1.1]>
Richard Klinger wrote:
> >
> > Much better :-)
> 
> Really? (o;
> 
> "drivers/ks8695eth.c" includes "asm/arch/platform.h" which not
> all boards have...especially not with the defines this driver
> requires...

He is right: your code breaks ALL other ARM boards:

-> MAKEALL arm
Configuring for assabet board...
ks8695eth.c:27:31: asm/arch/platform.h: No such file or directory
make[1]: *** [.depend] Error 1
make: *** [drivers/libdrivers.a] Error 2
arm-linux-size: u-boot: No such file or directory
Configuring for dnp1110 board...
ks8695eth.c:27:31: asm/arch/platform.h: No such file or directory
make[1]: *** [.depend] Error 1
make: *** [drivers/libdrivers.a] Error 2
arm-linux-size: u-boot: No such file or directory
Configuring for gcplus board...
ks8695eth.c:27:31: asm/arch/platform.h: No such file or directory
make[1]: *** [.depend] Error 1
make: *** [drivers/libdrivers.a] Error 2
arm-linux-size: u-boot: No such file or directory
Configuring for lart board...
ks8695eth.c:27:31: asm/arch/platform.h: No such file or directory
make[1]: *** [.depend] Error 1
make: *** [drivers/libdrivers.a] Error 2
arm-linux-size: u-boot: No such file or directory
Configuring for shannon board...
ks8695eth.c:27:31: asm/arch/platform.h: No such file or directory
make[1]: *** [.depend] Error 1
make: *** [drivers/libdrivers.a] Error 2
arm-linux-size: u-boot: No such file or directory
Configuring for B2 board...
ks8695eth.c:27:31: asm/arch/platform.h: No such file or directory
make[1]: *** [.depend] Error 1
make: *** [drivers/libdrivers.a] Error 2
arm-linux-size: u-boot: No such file or directory
Configuring for ep7312 board...
ks8695eth.c:27:31: asm/arch/platform.h: No such file or directory
make[1]: *** [.depend] Error 1
make: *** [drivers/libdrivers.a] Error 2
arm-linux-size: u-boot: No such file or directory
...

etc.

Didn't you run MAKEALL before submitting your patches? Grrrrghhh!


Please fix ASAP!!!

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The optimum committee has no members.
                                                   - Norman Augustine