[U-Boot-Users] [PATCH 1/2] add Kendein/Micrel KS8695P CPU support

[Greg Ungerer]

Wolfgang Denk wrote:
> Dear Greg,
> 
> in message <r02010500-1041-5A1EF226C91011D9BF6200039387ACB6@[10.0.1.1]>
> Richard Klinger wrote:
> 
>>>Much better :-)
>>
>>Really? (o;
>>
>>"drivers/ks8695eth.c" includes "asm/arch/platform.h" which not
>>all boards have...especially not with the defines this driver
>>requires...
> 
> 
> He is right: your code breaks ALL other ARM boards:
> 
> -> MAKEALL arm
> Configuring for assabet board...
> ks8695eth.c:27:31: asm/arch/platform.h: No such file or directory

Ok, it makes no sense (at least currently) to be compiling this driver
for any configuration not based on the KS8695 CPU. So the simple fix
is to define it out.


--- u-boot/drivers/ks8695eth.c.org      2005-05-23 11:02:44.877332792 +1000
+++ u-boot/drivers/ks8695eth.c  2005-05-23 11:02:33.722028656 +1000
@@ -24,6 +24,11 @@
  #include <malloc.h>
  #include <net.h>
  #include <asm/io.h>
+
+/****************************************************************************/
+#ifdef CONFIG_KS8695
+/****************************************************************************/
+
  #include <asm/arch/platform.h>

 
/****************************************************************************/
@@ -234,3 +239,4 @@
  }

 
/****************************************************************************/
+#endif /* CONFIG_KS8695 */



> 
> Didn't you run MAKEALL before submitting your patches? Grrrrghhh!

Well, I don't get clean results for it, and I haven't investiagted
why yet... Can I trust it??

Configuring for assabet board...
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_modsi3.o) uses hardware 
FP, whereas u-boot uses software FP
File in wrong format: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_modsi3.o)
make: *** [u-boot] Error 1
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for dnp1110 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for gcplus board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for lart board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for shannon board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for B2 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for ep7312 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for evb4510 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for impa7 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for modnet50 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for at91rm9200dk board...
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_divsi3.o) uses hardware 
FP, whereas u-boot uses software FP
File in wrong format: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_divsi3.o)
make: *** [u-boot] Error 1
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for cmc_pu2 board...
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_divsi3.o) uses hardware 
FP, whereas u-boot uses software FP
File in wrong format: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_divsi3.o)
make: *** [u-boot] Error 1
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for integratorcp board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for integratorap board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for lpd7a400 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for mx1ads board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for mx1fs2 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for omap1510inn board...
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_modsi3.o) uses hardware 
FP, whereas u-boot uses software FP
File in wrong format: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_modsi3.o)
make: *** [u-boot] Error 1
./MAKEALL: line 243: ppc_8xx-size: command not found
... configured for CS3 boot
Configuring for omap1610h2 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
... configured for CS3 boot
Configuring for omap1610inn board...
./MAKEALL: line 243: ppc_8xx-size: command not found
... configured for CS3 boot
Configuring for omap730p2 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for scb9328 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for smdk2400 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for smdk2410 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for trab board...
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_udivsi3.o) uses 
hardware FP, whereas trab_fkt uses software FP
Success: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_udivsi3.o)
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_umodsi3.o) uses 
hardware FP, whereas trab_fkt uses software FP
Success: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_umodsi3.o)
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_dvmd_lnx.o) uses 
hardware FP, whereas trab_fkt uses software FP
Success: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_dvmd_lnx.o)
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_udivdi3.o) uses 
hardware FP, whereas trab_fkt uses software FP
Success: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_udivdi3.o)
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_clz.o) uses hardware 
FP, whereas trab_fkt uses software FP
Success: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_clz.o)
make[1]: *** [trab_fkt.srec] Error 1
make: *** [board/trab/libtrab.a] Error 2
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for VCMA9 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for versatile board...
./MAKEALL: line 243: ppc_8xx-size: command not found
... boot from upper flash bank
Configuring for voiceblue board...
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_udivsi3.o) uses 
hardware FP, whereas eeprom uses software FP
Success: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_udivsi3.o)
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_umodsi3.o) uses 
hardware FP, whereas eeprom uses software FP
Success: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_umodsi3.o)
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_dvmd_lnx.o) uses 
hardware FP, whereas eeprom uses software FP
Success: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_dvmd_lnx.o)
make[1]: *** [eeprom.srec] Error 1
make: *** [board/voiceblue/libvoiceblue.a] Error 2
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for omap2420h4 board...
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_divsi3.o) uses FPA 
instructions, whereas u-boot does not
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_divsi3.o) uses hardware 
FP, whereas u-boot uses software FP
File in wrong format: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_divsi3.o)
make: *** [u-boot] Error 1
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for adsvix board...
pcmcia.c:39:2: warning: #warning "Board will only supply 5V, wait for 
next HW spin for selectable power"
cmd_pcmcia.c: In function `pcmcia_on':
cmd_pcmcia.c:343: warning: operation on `i' may be undefined
cmd_pcmcia.c: At top level:
cmd_pcmcia.c:305: warning: `hardware_disable' defined but not used
cmd_pcmcia.c:300: warning: `hardware_enable' defined but not used
cmd_pcmcia.c:310: warning: `voltage_set' defined but not used
arm-linux-ld: ERROR: 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_modsi3.o) uses hardware 
FP, whereas u-boot uses software FP
File in wrong format: failed to merge target specific data of file 
/usr/local/lib/gcc-lib/arm-linux/3.3.2/libgcc.a(_modsi3.o)
make: *** [u-boot] Error 1
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for cerf250 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for cradle board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for csb226 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for innokom board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for lubbock board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for wepep250 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for xaeniax board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for xm250 board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for xsengine board...
./MAKEALL: line 243: ppc_8xx-size: command not found
Configuring for ixdp425 board...
pci_indirect.c: In function `indirect_read_config_byte':
pci_indirect.c:94: warning: passing arg 1 of `in_8' from incompatible 
pointer type
pci_indirect.c: In function `indirect_read_config_word':
pci_indirect.c:95: warning: passing arg 1 of `in_le16' from incompatible 
pointer type
pci_indirect.c: In function `indirect_write_config_byte':
pci_indirect.c:102: warning: passing arg 1 of `out_8' from incompatible 
pointer type
pci_indirect.c: In function `indirect_write_config_word':
pci_indirect.c:103: warning: passing arg 1 of `out_le16' from 
incompatible pointer type
./MAKEALL: line 243: ppc_8xx-size: command not found


Regards
Greg