[U-Boot-Users] [DNX#2006071842000016] [patch] Added support for Embedded [...]

[Jeff Mann]

> Also, I consider it a very bad ide to hard-wire MAC and  IP  addreses 
> in  the  board config file. And pre-defining constants like "unknown"
> for hostname, "/nfsroot" for rootpath or "your.uImage"  for  bootfile 
> is,  well,  let's say not very helpful. If there are no useful common 
> setttings it is better NOT to set such variables at all.
I thought that "hard-wire MAC and  IP  addresses in  the  board config
file" were just compiled into default environmental variables, not
hard-wired. 

Would it then be appropriate to do something like this:
  #if 0 /* user option to compile with default network values */
  Default ip settings
  Hostname, bootfile, rootpath constants
  #endif
So that the *option* of setting up default settings is given to the
users in case that makes sense for their applications?

> Finally, I recommend to use "${...}"  variable  syntax  in  all  your 
> definitions, as this makes it possible to switch command line parsers 
> without need to change the environment definitions.
That is a valuable point. I will do this. 


> * Please keep lists sorted (like board names in MAKEALL)
Of course. Additionally, I just changed the 8xx section from columns to
rows so that they would compile in the correct order now. 

-JM