[DNX#2006033142000231] [U-Boot-Users] [Patch] KVME080 Support
DENX Support System
support at denx.de
Fri Mar 31 23:50:09 CEST 2006
Hello list,
inside the automatic U-Boot patch tracking system a new ticket
[DNX#2006033142000231] was created:
<snip>
> Hi Wolfgang,
>
> Wolfgang Denk wrote:
> > In message <004e01c5a3db$3840e6f0$212d4cdc at smkim> you wrote:
>
> [snip]
>
> > And please cleanup your code before re-submitting:
> >
> > * It violates the coding style requirements (trailing white space).
> >
> > * Using globally visible preprocessor defines like FLASH_WRITE64 is
> > not acceptable (you also forgot to document these, but that would
> > help either), and defining such code in the board config file is
> > the wrong way to implement it either. The board config file is -
> > ummm, a _configuration_ file, but does not contain source code.
>
> IIRC, you posted a couple of scripts that tested for formatting
> violations. Per my previous suggestion of putting the patch rules on
> your web site, I would like to see the formatting test scripts posted
> too. If these were on the DULG twiki, they could be collaboratively
> tuned.
>
> [snip]
>
> > Rejected, sorry.
> >
> > Best regards,
> >
> > Wolfgang Denk
>
> Thanks,
> gvb
</snip>
Your U-Boot support team
More information about the U-Boot
mailing list