[U-Boot-Users] quit unclear code in cpu/arm920t/at91rm9200/ether.c Line:220

Wolfgang Denk wd at denx.de
Tue May 2 15:17:57 CEST 2006

In message <20060502115845.GA20961 at tuxedo.skovlyporten.dk> you wrote:
> makes no sense and always returns true. IMHO we should remove it
> completely and always run the PhyOps.Init function. Checking on the
> EMAC_ISR register is also wrong since it indicates link changes and is
> AFAIK phy dependent and needs to have interrupts enabled.
> On most at91rm9200 based systems I have worked on, I do not have link
> yet when PhyOps.Init is called. So I have added a small loop in my phy
> code waiting for link before returning (max 5 seconds).

Maybe you can submit a patch?

Thanks in advance.

Best regards,

Wolfgang Denk

Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the realm of scientific observation, luck is granted only to those
who are prepared.                                     - Louis Pasteur

More information about the U-Boot mailing list