[U-Boot-Users] PATCH: Add command support for second I2Ccontroller

[Wolfgang Denk]

In message <1147798734.16780.201.camel at saruman.qstreams.net> you wrote:
> One sticky part is, how do we deal with the 'CFG_I2C_NOPROBE' stuff?
> This is a list defined for each board of chips that the 'iprobe' command
> should bypass. The current implementation has this list instantiated as
> a static array within 'cmd_i2c.c', and is of course relevant only to the
> first bus.  As we add buses, it gets ugly.  How about defining a
> structure that includes all bus information:
> 
> typedef struct _i2c_bus
> {
> 	int	baseAddress
> 	int	busSpeed;
> 	uchar	noProbeList[];
> 	...  /* whatever else might be useful */
> } i2c_bus;

Please keep as small as possible.

> On the other hand, maybe the NOPROBE list is rarely used and we
> shouldn't be worrying too much about it.

Ummm... at least the following board configurations use it:

include/configs/MPC8540ADS.h
include/configs/MPC8541CDS.h
include/configs/MPC8555CDS.h
include/configs/MPC8560ADS.h
include/configs/PM854.h
include/configs/SBC8540.h
include/configs/SBC8560.h
include/configs/XPEDITE1K.h
include/configs/bubinga.h
include/configs/ebony.h
include/configs/ocotea.h
include/configs/sbc8560.h
include/configs/stxgp3.h
include/configs/MPC8540EVAL.h
include/configs/MPC8548CDS.h
include/configs/PM856.h
include/configs/KAREF.h
include/configs/METROBOX.h
include/configs/TQM85xx.h
include/configs/p3p440.h
include/configs/MPC8349EMDS.h

That's definitely more than "rarely used".

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Make it right before you make it faster.