[U-Boot-Users] PATCH: Add command support for second I2Ccontroller
wd at denx.de
Tue May 16 22:15:12 CEST 2006
In message <1147798734.16780.201.camel at saruman.qstreams.net> you wrote:
> One sticky part is, how do we deal with the 'CFG_I2C_NOPROBE' stuff?
> This is a list defined for each board of chips that the 'iprobe' command
> should bypass. The current implementation has this list instantiated as
> a static array within 'cmd_i2c.c', and is of course relevant only to the
> first bus. As we add buses, it gets ugly. How about defining a
> structure that includes all bus information:
> typedef struct _i2c_bus
> int baseAddress
> int busSpeed;
> uchar noProbeList;
> ... /* whatever else might be useful */
> } i2c_bus;
Please keep as small as possible.
> On the other hand, maybe the NOPROBE list is rarely used and we
> shouldn't be worrying too much about it.
Ummm... at least the following board configurations use it:
That's definitely more than "rarely used".
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Make it right before you make it faster.
More information about the U-Boot