[U-Boot-Users] PATCH: Add command support for second I2Ccontroller
Ben Warren
bwarren at qstreams.com
Tue May 16 22:26:25 CEST 2006
I'm working on a solution that retains NOPROBE support, while keeping
the footprint as small as possible. Should have a patch tomorrow.
regards,
Ben
On Tue, 2006-05-16 at 22:15 +0200, Wolfgang Denk wrote:
> In message <1147798734.16780.201.camel at saruman.qstreams.net> you wrote:
> > One sticky part is, how do we deal with the 'CFG_I2C_NOPROBE' stuff?
> > This is a list defined for each board of chips that the 'iprobe' command
> > should bypass. The current implementation has this list instantiated as
> > a static array within 'cmd_i2c.c', and is of course relevant only to the
> > first bus. As we add buses, it gets ugly. How about defining a
> > structure that includes all bus information:
> >
> > typedef struct _i2c_bus
> > {
> > int baseAddress
> > int busSpeed;
> > uchar noProbeList[];
> > ... /* whatever else might be useful */
> > } i2c_bus;
>
> Please keep as small as possible.
>
> > On the other hand, maybe the NOPROBE list is rarely used and we
> > shouldn't be worrying too much about it.
>
> Ummm... at least the following board configurations use it:
>
> include/configs/MPC8540ADS.h
> include/configs/MPC8541CDS.h
> include/configs/MPC8555CDS.h
> include/configs/MPC8560ADS.h
> include/configs/PM854.h
> include/configs/SBC8540.h
> include/configs/SBC8560.h
> include/configs/XPEDITE1K.h
> include/configs/bubinga.h
> include/configs/ebony.h
> include/configs/ocotea.h
> include/configs/sbc8560.h
> include/configs/stxgp3.h
> include/configs/MPC8540EVAL.h
> include/configs/MPC8548CDS.h
> include/configs/PM856.h
> include/configs/KAREF.h
> include/configs/METROBOX.h
> include/configs/TQM85xx.h
> include/configs/p3p440.h
> include/configs/MPC8349EMDS.h
>
> That's definitely more than "rarely used".
>
> Best regards,
>
> Wolfgang Denk
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20060516/2d38da91/attachment.htm
More information about the U-Boot
mailing list