[U-Boot-Users] Why is ENV_IS_EMBEDDED globally define when NAND bootloader is built ?

Spence Nick-rxtd10 Nick.Spence at freescale.com
Mon Nov 20 09:16:38 CET 2006

Hello Stefan,
I am trying to set up a NAND_SPL bootloader for a different PowerPC
I want to store the environment variables in the NAND Flash at a
location above the boot loader, so that I can reprogram the bootloader
without overwriting the variables when I copy the u-boot-nand.bin image
into the NAND flash.
However in the changes made on Sept 12, the include/environment.h file
was modified to define ENV_IS_EMBEDDED whenever CONFIG_NAND_U_BOOT is
Is there any reason that this configuration setting cannot be moved into
the board specific include file instead ?
diff --git a/include/configs/sequoia.h b/include/configs/sequoia.h
index 3a76315..33ff4cf 100644
--- a/include/configs/sequoia.h
+++ b/include/configs/sequoia.h
@@ -102,6 +102,7 @@ #if !defined(CONFIG_NAND_U_BOOT) && !def
 #define CFG_ENV_IS_IN_FLASH     1 /* use FLASH for environment vars */
 #define CFG_ENV_IS_IN_NAND 1 /* use NAND for environment vars */
+#define ENV_IS_EMBEDDED  1 /* use embedded environment */
diff --git a/include/environment.h b/include/environment.h
index 26b0712..422f800 100644
--- a/include/environment.h
+++ b/include/environment.h
@@ -79,10 +79,6 @@ # endif
 # endif
-# if defined(CONFIG_NAND_U_BOOT)
-/* Use embedded environment in NAND boot versions */
-#  define ENV_IS_EMBEDDED 1
-# endif
 #endif /* CFG_ENV_IS_IN_NAND */

Am I missing something ?


Nick Spence
Freescale Semiconductor,
1300 N. Alma School Road, Chandler, AZ 85224

More information about the U-Boot mailing list