[U-Boot-Users] Please pull u-boot-83xx.git

[Wolfgang Denk]

Dear Timur,

in message <456B1543.2040006 at freescale.com> you wrote:
>
> > TQ has a pretty long list of configuration options for their modules,
> > and the change above will probably break quite a few, or most.
> 
> The above change is necessary to make the board compatible with the flash-size 
> code in mpc83xx/start.S:

Maybe we can find a better way to address this issue.

> Previously, this code just assumed that flash was 8MB.  However, the 8349ITX has 
> 16MB of flash.  Rather than have #ifdefs in start.S, this code was changed to 
> calculate the correct value for LBLAWAR1 based on CFG_FLASH_SIZE.

The problem is that I don't want to see any  such  hard-coded  sizes.
What  I want is documented in the (very old!) "System Initialization"
section in the README: we may have to configure for a  maximum  size,
but  except  from that, U-Boot should auto-adjust to different seizes
of RAM and flash memory.

> I believe that this code is the most elegant solution to the problem, however it 
> does require that each board header file define a value for CFG_FLASH_SIZE.  The 
> alternative would be to add these lines above the new code:

What exactly is the meaning of CFG_FLASH_SIZE in your code?

Is  this  a  _maximum_  size  which  is  supported  by   this   board
configuration, or the exact size that must be presen on the board? If
the  board  comes  with  a different flash size, what will the U-Boot
start messages report, and what size will  be  actually  mapped  once
U-Boot enters interactive mode?

> #ifndef CFG_FLASH_SIZE
> #define CFG_FLASH_SIZE 8
> #endif
> 
> If you prefer that we use this approach, then we can make that change.  However, 

No, this is even worse, I think.


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Be kind to unkind people - they need it the most.