[U-Boot-Users] [PATCH] Set fileaddr and filesize environment variables upon download of a file

[Laurent Pinchart]

> In message <200609201042.12600.laurent.pinchart at tbox.biz> you wrote:
> > load-from-disk commands set the fileaddr and filesize environment
> > variables upon completion. This patch adds the same functionality for
> > load-from-network commands (BOOTP, TFTP, NFS, ...).
>
> I reject your patch, as it is redundant.
>
> > The fileaddr environment variable is set to the address at which the file
> > has
>
> This is redundant.  The  information  is  already  available  in  the
> loadaddr environment variable.

The current code (git head) does not set the loadaddr environment variable 
upon completion of the tftpboot command.

You might have mistaken the purpose of my patch. The loadaddr environment 
variable is the default address used by load commands. The load-from-network 
commands already support the loadaddr variable. What my patch adds to the 
load-from-network commands is the ability to set the fileaddr and filesize 
variables, much like the load-from-disks commands do. This is not supported 
yet.

> > been loaded. The filesize environment variable is set to the size of the
> > file in bytes.
>
> This is redundant. The filesize variable already gets set by the
> current code.

Best regards,

Laurent Pinchart