[U-Boot-Users] [PATCH] Set fileaddr and filesize environment variables upon download of a file

[Wolfgang Denk]

In message <200610101121.54820.laurent.pinchart at tbox.biz> you wrote:
>
> You might have mistaken the purpose of my patch. The loadaddr environment 
> variable is the default address used by load commands. The load-from-network 
> commands already support the loadaddr variable. What my patch adds to the 
> load-from-network commands is the ability to set the fileaddr and filesize 
> variables, much like the load-from-disks commands do. This is not supported 
> yet.

As mentioned before, your patch is redundand.

NetLoop() in  "net/net.c"  will  set  "fileaddr"  after  a  succesful
download. Also, "filesize" already gets set there.

This has been available for years.

Demo:

=> print fileaddr filesize
## Error: "fileaddr" not defined
## Error: "filesize" not defined
=> tftp 12345 /tftpboot/ocotea/uImage
Waiting for PHY auto negotiation to complete.. done
ENET Speed is 100 Mbps - FULL duplex connection
Using ppc_4xx_eth0 device
TFTP from server 192.168.1.1; our IP address is 192.168.80.2
Filename '/tftpboot/ocotea/uImage'.
Load address: 0x12345
Loading: #################################################################
         #################################################################
         ##########################################################
done
Bytes transferred = 957895 (e9dc7 hex)
=> print fileaddr filesize
fileaddr=12345
filesize=e9dc7
=> 


I don't get what you want to add - what you're asking for is already
there, and has been there for a long, long time.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
That's their goal, remember, a goal that's really contrary to that of
the programmer or administrator. We just want to get our  jobs  done.
$Bill  just  wants  to  become  $$Bill. These aren't even marginallly
congruent.
         -- Tom Christiansen in <6jhtqk$qls$1 at csnews.cs.colorado.edu>