[U-Boot-Users] [PATCH] New NAND subsystem: mtd like commands support jffs2 and bad blocks

Guido Classen clagix at gmail.com
Thu Oct 12 10:48:06 CEST 2006


Hi Stefan,

>
> Patch applied with little changes. Thanks again.
>

thank you for applying!

There are two issues I want to remark:


> --- a/lib_generic/crc32.c
> +++ b/lib_generic/crc32.c
> @@ -171,9 +171,8 @@ uLong ZEXPORT crc32(crc, buf, len)
> return crc ^ 0xffffffffL;
> }
> -#if (CONFIG_COMMANDS & CFG_CMD_JFFS2) \
> - || (CONFIG_COMMANDS & CFG_CMD_NAND) && !defined(CFG_NAND_LEGACY)
> -
> +#if ((CONFIG_COMMANDS & CFG_CMD_JFFS2) || (CONFIG_COMMANDS & CFG_CMD_NAND)) \
> + && !defined(CFG_NAND_LEGACY)

This means you can't use the JFFS2 filesystem with legacy NAND subsystem.
Was this meant so? I am not sure here since I don't use the JFFS2 filesystem
in u-boot. Maybe wrong set parenthesis?

I think the right code should look like this:
#if (CONFIG_COMMANDS & CFG_CMD_JFFS2) || ((CONFIG_COMMANDS & CFG_CMD_NAND) \
 && !defined(CFG_NAND_LEGACY))

Spelling fix, cmd_nand.c line 254
"shure" => "sure"
is open. Stefan can you fix this?

Regards
  Guido




More information about the U-Boot mailing list