[U-Boot-Users] [PATCH] New NAND subsystem: mtd like commands support jffs2 and bad blocks

Wolfgang Denk wd at denx.de
Thu Oct 12 11:08:52 CEST 2006


Dear Guido,

in message <5c01f02f0610120148i546bb178tb2f1f1b011f9d356 at mail.gmail.com> you wrote:
> 
> > -#if (CONFIG_COMMANDS & CFG_CMD_JFFS2) \
> > - || (CONFIG_COMMANDS & CFG_CMD_NAND) && !defined(CFG_NAND_LEGACY)
> > -
> > +#if ((CONFIG_COMMANDS & CFG_CMD_JFFS2) || (CONFIG_COMMANDS & CFG_CMD_NAND)) \
> > + && !defined(CFG_NAND_LEGACY)

You are right -  this modification was wrong.

> This means you can't use the JFFS2 filesystem with legacy NAND subsystem.
> Was this meant so? I am not sure here since I don't use the JFFS2 filesystem
> in u-boot. Maybe wrong set parenthesis?

Well spotted. Fixed.

> Spelling fix, cmd_nand.c line 254
> "shure" => "sure"
> is open. Stefan can you fix this?

Done.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I find this a nice feature but it is not according to  the  documen-
tation. Or is it a BUG?"   "Let's call it an accidental feature. :-)"
                       - Larry Wall in <6909 at jpl-devvax.JPL.NASA.GOV>




More information about the U-Boot mailing list