[U-Boot-Users] [PATCH] New NAND subsystem: mtd like commands support jffs2 and bad blocks

Wolfgang Denk wd at denx.de
Sat Oct 7 20:56:22 CEST 2006


In message <200610071235.18760.sr at denx.de> Stefan Roese wrote:
> 
...
> Indentation is incorrect here.
...
> Again, please not 2 empty lines.
...
> Opening brace in "if-statement" line please.
...
> > +		if (!nand_unlock( nand, off, size) )
> 
> No space before the colsing brace here.

etc. etc.

I strongly recommend to read the README, section Coding Style,  which
explicitely  explains the Coding Style requirements and shows ways to
correctly reformat corrupted code.


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"This is a test of the Emergency Broadcast System. If this had been an
actual emergency, do you really think we'd stick around to tell you?"




More information about the U-Boot mailing list