[U-Boot-Users] [PATCH] Fix possible uninitialized variable compiler warning.

[Grant Likely]

On 10/12/06, Wolfgang Denk <wd at denx.de> wrote:
> Dear Grant,
>
> in message <528646bc0610121208i2b9b3b4at8e7de8c0b3800276 at mail.gmail.com> you wrote:
> >
> > > Maybe there is a clever way to auto-generate the CHANGELOG  from  the
> > > commit  message;  I  tried  this  once and failed. Ummm... just tried
> > > again and found that it's actually working  when  I  use  git-commit;
> > > however,  it  seems  that cg-commit does not run the pre-commit hook.
> > > Maybe a cogito issue. I'll ask...
>
> I asked, and received pretty clear statements: even if we'd  use  the
> pre-commit  hook  it  wouldn't  work  as  this run before editing the
> commit message. On the other hand, as long as we  manually  edit  the
> commit  message  we can point EDITOR to some wrapper script. But also
> the general opinion about my idea was  pretty  clear.  Linus  himself
> wrote unequivocally: "Why? That's just stupid."

Can we please just punt the in-tree CHANGELOG file?  Please please
please please?

Tarballs can always have it; It can always be generated in a local
copy; But does it really need to be updated manually in every patch?

> > My preference is definitely #2.  I guess my opinion is: development is
> > going to occur in off-mainline trees regardless.  Most of them are
> > private (and therefore irrelevant to this discussion), but some like
> > jdl's and the freescale trees are public.  The changes have been
> > around a long time, but they are still not in mainline.  In this case,
> > I do not think replying to one of the original patches is relevant or
> > convenient due to additional changes applied on top, the amount of
> > time that has passed, and the git workflow.
>
> You convinced me. Thanks for the explanation.

:)  Thanks, I appreciate your consideration.

>
> > On rereading my comment here, I realize it's harsher than I intended.
> > I'm sorry.  I just wanted to state my disagreement, but this statement
> > could be read as a personal comment.  I apologize.
>
> No offence taken. I often sound harsher than I intend, too. I know
> that lack of time is no real excuse, but I don't have a better one.

Hooray.  This is much better than flared tempers.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195