[U-Boot-Users] ixdp 465

Michael Trimarchi michael at evidence.eu.com
Mon Oct 23 09:58:33 CEST 2006


Hi,
Wolfgang Denk wrote:

>Such a plain diff output is not a patch, it cannot be applied. Please
>make sure to read the README, section Submitting  Patches.  You  MUST
>use the correct options when creating the patch.
>
Ok, some people ask me for a patch because they need it. I will produce 
a better patch.

>
>Also mind the size limitations on the mailing list.
>
>And make sure to stick  to  the  required  coding  style,  your  code
>contains lots of problems (indentation by spaces instead of TABs, C++
>comments, trailing white space, etc.).
>
thank's,
I'm going to fix

>
>Also never add change log entires to any files. We use git for this
>purpose.
>
Ok

>
>Make sure your code does not contain dead code (#if 0 etc.).
>
The dead code is already present,  I just add my code, without dead 
code. Thank's a lot for your comment

>
>
>
>Please cleanup and resubmit.
>
>Best regards,
>
>Wolfgang Denk
>  
>
Regards Michael






More information about the U-Boot mailing list