[U-Boot-Users] [PATCH 6/6] ATSTK1000 and ATSTK1002 board support

[Wolfgang Denk]

In message <20060906162525.3aac817f at cad-250-152.norway.atmel.com> you wrote:
>
> The attached patch adds support for the ATSTK1000 development board and
> the ATSTK1002 CPU daughterboard for AT32AP7000. Please see the patch
> header for details.
> 
> CHANGELOG:
> 	Add support for the ATSTK1000 development board

Mostly added, thanks.

I omitted the folowing parts of your patch:

Index: u-boot-1.1.4-git/Makefile
===================================================================
--- u-boot-1.1.4-git.orig/Makefile	2006-09-06 15:32:47.000000000 +0200
+++ u-boot-1.1.4-git/Makefile	2006-09-06 15:35:26.000000000 +0200
@@ -2060,6 +2060,13 @@ pb1000_config		: 	unconfig
 ## AT32AP7xxx
 #########################################################################
 
+atstk1002_config	:	unconfig
+	@./mkconfig $(@:_config=) avr32 at32ap atstk1000 NULL at32ap7000
+
+$(obj)board/atstk1000/u-boot.lds: board/atstk1000/u-boot.lds.S	\
+				  $(obj)include/config.h
+	$(CPP) $(AFLAGS) -P -o $@ $<
+

Please don't put "board" specific build rules in the top level
Makefile. These belong into the board directory's makefile.

[Please submit a new, incremental patch against current top  of  tree
in git repo.]

Thanks.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"IBM uses what I like to call the 'hole-in-the-ground  technique'  to
destroy  the  competition.....  IBM digs a big HOLE in the ground and
covers it with leaves. It then puts a big POT OF GOLD nearby. Then it
gives the call, 'Hey, look at all this gold, get over here fast.'  As
soon  as  the competitor approaches the pot, he falls into the pit"
                                                     - John C. Dvorak