[U-Boot-Users] [PATCH 6/6] ATSTK1000 and ATSTK1002 board support

Haavard Skinnemoen hskinnemoen at atmel.com
Tue Oct 24 15:20:48 CEST 2006


On Tue, 24 Oct 2006 14:59:52 +0200
Wolfgang Denk <wd at denx.de> wrote:

> +$(obj)board/atstk1000/u-boot.lds:
> board/atstk1000/u-boot.lds.S	\
> +				  $(obj)include/config.h
> +	$(CPP) $(AFLAGS) -P -o $@ $<
> +
> 
> Please don't put "board" specific build rules in the top level
> Makefile. These belong into the board directory's makefile.

Hmm...I can't quite remember the reason for doing this. I think it was
that the board's config.mk was included before the default rule, so it
would override it.

I'll see if I can figure out some other solution.

> [Please submit a new, incremental patch against current top  of  tree
> in git repo.]

Will do. Thanks for applying my patches :-)

Btw, did you apply this one _and_ the other STK1000 patch? I only
intended you to merge one of them (preferably the other one since it
adds the atstk1000 directory under boards/atmel, as suggested by
Stefan.)

Haavard




More information about the U-Boot mailing list