[U-Boot-Users] Antw: Re: [PATCH] Add first Netstal board HCU4

[Wolfgang Denk]

Dear Niklaus,

in message <ev5roc$qoo$1 at sea.gmane.org> you wrote:
> 
> +#define mtsdram0(reg, data)    mtdcr(memcfga,reg);mtdcr(memcfgd,data)

This is bad style. Any such multi-statement macro  definition  should
be encapsulated in a "do { ... } while (0)" frame.

> +       if (bank != 0)
> +       {
> +               printf("\n%s: only bank 0 supported",  __FUNCTION__);
> +               return;
> +       }

Bad brace style.

Indentation not by TAB.


Please clean up!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All your people must learn before you can reach for the stars.
	-- Kirk, "The Gamesters of Triskelion", stardate 3259.2