[U-Boot-Users] Antw: Re: [PATCH] Add first Netstal board HCU4

Wolfgang Denk wd at denx.de
Fri Apr 6 21:39:27 CEST 2007

Dear Niklaus,

in message <ev5roc$qoo$1 at sea.gmane.org> you wrote:
> Here my reworked patch. Tried a follow all of your comments.

There are some coding style violations: indentation not by TAB.

Please write comments in English language, thanks.

include/configs/hcu4.h is formatted in a way  that  makes  it  mostly
unreadable. You may want to clean this up a bit.

You use a private flash driver for something that looks as if it was
CFI compatible - why don't you use the CFI driver?

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Where shall I begin, please your Majesty?" he asked. "Begin  at  the
beginning,"  the  King said, gravely, "and go on till you come to the
end: then stop."    - Alice's Adventures in Wonderland, Lewis Carroll

More information about the U-Boot mailing list