[U-Boot-Users] Antw: Re: [PATCH] Add first Netstal board HCU4

[Stefan Roese]

On Friday 06 April 2007 21:39, Wolfgang Denk wrote:
> in message <ev5roc$qoo$1 at sea.gmane.org> you wrote:
> > Here my reworked patch. Tried a follow all of your comments.
>
> There are some coding style violations: indentation not by TAB.
>
> Please write comments in English language, thanks.
>
> include/configs/hcu4.h is formatted in a way  that  makes  it  mostly
> unreadable. You may want to clean this up a bit.
>
> You use a private flash driver for something that looks as if it was
> CFI compatible - why don't you use the CFI driver?

This has been discussed before (I asked the same question). IIRC the board 
used an 8bit wide non CFI-compatible FLASH and an 16bit wide CFI compatible 
FLASH device. With the current CFI implementation this setup is not supported 
so a "custom" driver has to be used.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
=====================================================================