[U-Boot-Users] [PATCH] Fix use of "void *" for block dev read/write buffer pointers

[Greg Lopp]

On 4/12/07, Grant Likely <grant.likely at secretlab.ca> wrote:

>
> A few comments:
>
> 1. you need to add a Signed-of-by:" line at the bottom of your comment
> block


Oops. I started reading Documentation/SubmittingPatches. I just didn't get
all the way through.

2. Looks like whitespace has been mangled in this patch.  Tabs are now
> spaces and long lines have been wrapped.  The patch doesn't apply.
> Your mail client probably did this to you.


Which is why I've changed to an attachment.

> blocksize in ulong */
> > +               buffer+=(cnt*ATAPI_READ_BLOCK_SIZE); /* ulong
> > blocksize in ulong */
>
> 3. Now that buffer is incremented by bytes, the comment no longer
> applies.  Remove it in your patch.


Fixed.......resubmitting
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20070412/ccf8b24a/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmd_ide.patch
Type: application/octet-stream
Size: 961 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070412/ccf8b24a/attachment.obj