[U-Boot-Users] [PATCH] Fix use of "void *" for block dev read/write buffer pointers

[Grant Likely]

On 4/12/07, Greg Lopp <lopp at pobox.com> wrote:
> On 4/12/07, Grant Likely <grant.likely at secretlab.ca> wrote:
> > 2. Looks like whitespace has been mangled in this patch.  Tabs are now
> > spaces and long lines have been wrapped.  The patch doesn't apply.
> > Your mail client probably did this to you.
>
> Which is why I've changed to an attachment.

Looks better now.

> > > blocksize in ulong */
> > > +               buffer+=(cnt*ATAPI_READ_BLOCK_SIZE); /*
> ulong
> > > blocksize in ulong */
> >
> > 3. Now that buffer is incremented by bytes, the comment no longer
> > applies.  Remove it in your patch.
>
> Fixed.......resubmitting

> -             buffer+=cnt*(ATAPI_READ_BLOCK_SIZE/4); /* ulong blocksize in ulong */
> +             buffer+=(cnt*ATAPI_READ_BLOCK_SIZE); /* ulong blocksize in ulong */

The comment at the end of the line still needs to be removed as it is no
longer accurate.

> Signed-of-by: Greg Lopp <lopp at pobox.com>

'off' is spelt with 2 f's.  :-P

Otherwise, looks good.  Fix those two minor points and resubmit, and I'll
ack it and poke Stefan to pick it up.

Thanks again.
g.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195