[U-Boot-Users] [PATCH] Fix use of "void *" for block dev read/write buffer pointers

[Greg Lopp]

On 4/12/07, Grant Likely <grant.likely at secretlab.ca> wrote:
> On 4/12/07, Greg Lopp <lopp at pobox.com> wrote:
> > On 4/12/07, Grant Likely <grant.likely at secretlab.ca> wrote:
> > > 2. Looks like whitespace has been mangled in this patch.  Tabs are now
> > > spaces and long lines have been wrapped.  The patch doesn't apply.
> > > Your mail client probably did this to you.
> >
> > Which is why I've changed to an attachment.
>
> Looks better now.
>
> > > > blocksize in ulong */
> > > > +               buffer+=(cnt*ATAPI_READ_BLOCK_SIZE); /*
> > ulong
> > > > blocksize in ulong */
> > >
> > > 3. Now that buffer is incremented by bytes, the comment no longer
> > > applies.  Remove it in your patch.
> >
> > Fixed.......resubmitting
>
> > -             buffer+=cnt*(ATAPI_READ_BLOCK_SIZE/4); /* ulong blocksize in ulong */
> > +             buffer+=(cnt*ATAPI_READ_BLOCK_SIZE); /* ulong blocksize in ulong */
>
> The comment at the end of the line still needs to be removed as it is no
> longer accurate.
Lost in the shuffle when wrestling with the mail client.

>
> > Signed-of-by: Greg Lopp <lopp at pobox.com>
>
> 'off' is spelt with 2 f's.  :-P
Out and out stupidity.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmd_ide.patch
Type: application/octet-stream
Size: 934 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070412/c667de59/attachment.obj