[U-Boot-Users] [PATCH] Fix use of "void *" for block dev read/write buffer pointers
sr at denx.de
Fri Apr 13 09:18:41 CEST 2007
On Friday 13 April 2007 08:54, Grant Likely wrote:
> > > Denis, could you please take a look at this patch and let me know if
> > > this patch supersedes your patch:
> > >
> > > "Re: [U-Boot-Users] [PATCH] Fix bugs in cmd_ide.c and cmd_scsi.c"
> > >
> > > from April, 2nd?
> > My patch from April, 2nd, fixes this issue already. In my patch I decided
> > to just cast the pointer back to ulong *, since I don't know if it is a
> > good idea to increment a pointer to void *.
> Incrementing a void* is safe.
> Personally, I prefer the solution in Greg's patch.
I appied Greg's patch and the device# part of Denis's patch to my
u-boot-ppc4xx repository. Please give it a try and let me know if the issues
are fixed now:
Then I'll ask Wolfgang to pull from my repository.
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
More information about the U-Boot