[U-Boot-Users] [PATCH] Fix use of "void *" for block dev read/write buffer pointers

[Grant Likely]

On 4/13/07, Denis Peter <d.peter at mpl.ch> wrote:
> Hello Stefan,
>
> On Friday 13 April 2007 07:56, Stefan Roese wrote:
> > Hi Denis,
> >
> > On Thursday 12 April 2007 22:27, Grant Likely wrote:
> > > On 4/12/07, Greg Lopp <lopp at pobox.com> wrote:
> > > > Signed-off-by: Greg Lopp <lopp at pobox.com>
> > >
> > > Acked-by: Grant Likely <grant.likely at secretlab.ca>
> > >
> > > Stefan, can you pick this one up please?
> >
> > Yes I will. Just checking with an older patch that tried to fix this issue:
> >
> > Denis, could you please take a look at this patch and let me know if this
> > patch supersedes your patch:
> >
> > "Re: [U-Boot-Users] [PATCH] Fix bugs in cmd_ide.c and cmd_scsi.c"
> >
> > from April, 2nd?
> >
>
> My patch from April, 2nd, fixes this issue already. In my patch I decided to just
> cast the pointer back to ulong *, since I don't know if it is a good idea to increment
> a pointer to void *.

Incrementing a void* is safe.

Personally, I prefer the solution in Greg's patch.

Cheers,
g.

--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195