[U-Boot-Users] [PATCH 2/4] emaclite

Wolfgang Denk wd at denx.de
Sun Aug 5 22:05:17 CEST 2007


In message <001801c7d792$54b4ca80$0500a8c0 at monstrone> you wrote:
> Signed-off-by: Michal Simek <monstr at monstr.eu>
> 
> Emaclite driver for Microblaze

NAK.

Please clean up coding style (indentation, trailing white space,
etc.). Also please use variable and function names according to
coding style rules, i. e. "do not use cute names like
ThisVariableIsATemporaryCounter." ... "mixed-case names are frowned
upon".

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
That said, there may be good reasons for what you did beyond obsequi-
ous sycophantic parody. Perhaps you might be so kind as to elucidate.
         -- Tom Christiansen in <5ldjbm$jtk$1 at csnews.cs.colorado.edu>




More information about the U-Boot mailing list