[U-Boot-Users] [PATCH 2/4] emaclite

Michal Simek monstr at seznam.cz
Mon Aug 6 22:00:01 CEST 2007


> Please clean up coding style (indentation, trailing white space,
> etc.). Also please use variable and function names according to
> coding style rules, i. e. "do not use cute names like
> ThisVariableIsATemporaryCounter." ... "mixed-case names are frowned
> upon".
>

I fix cute name from emac drivers but I think you have cute code in your 
code too.

You can see net/net.c file and following functions.

void NetReceive
ushort getenv_VLAN
IPaddr_t getenv_IPaddr
print_IPaddr
ushort string_to_VLAN

I think mixed-case names are really frowned.

Best regards,
Michal Simek 





More information about the U-Boot mailing list