[U-Boot-Users] MAKEALL patch

[Mike Frysinger]

On Sunday 05 August 2007, Wolfgang Denk wrote:
> In message <006f01c7d762$3976ead0$0500a8c0 at monstrone> you wrote:
> > Corection MAKEALL script.
> >
> > Signed of by: Michal Simek <monstr at monstr.eu>
> >
> >
> > diff --git a/MAKEALL b/MAKEALL
> > index 127faa8..2b44244 100755
> > --- a/MAKEALL
> > +++ b/MAKEALL
> > @@ -348,7 +348,7 @@ build_target() {
> >   ${MAKE} ${JOBS} all 2>&1 >${LOG_DIR}/$target.MAKELOG \
> >
> >      | tee ${LOG_DIR}/$target.ERR
> >
> > - ${CROSS_COMPILE:-ppc_8xx-}size ${BUILD_DIR}/u-boot \
> > + ${CROSS_COMPILE}size ${BUILD_DIR}/u-boot \
> >
> >      | tee -a ${LOG_DIR}/$target.MAKELOG
> >
> >  }
>
> What is the specific bug you intend to fix here?  Using  ppc_8xx-size
> in  case  CROSS_COMPILE is not set is not worse than using the native
> "size" command, it seems. Actually, given the fact that the  majority
> supported of boards are PowerPC, it is right in most cases.
>
> So why do you think it should be changed?

ive posted this patch a few times but never gotten a response ...

this code is wrong because ppc_8xx-size rarely exists for people who are not 
doing ppc development while size almost always exists.

so while the toplevel Makefile will setup a default CROSS prefix based on the 
board config, the MAKEALL script does not have access to that information, so 
for everyone who lacks ppc_8xx-size, using the MAKEALL script yields annoying 
broken output by default.

consider my typical use case:
./MAKEALL blackfin
i do not have CROSS_COMPILE set in my env and this is OK because the top level 
Makefile sets it by default to bfin-uclinux-.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070806/b37b08c4/attachment.pgp