[U-Boot-Users] [ARM] TI DaVinci support, 2nd attempt [0/5]

[ksi at koi8.net]

On Tue, 7 Aug 2007, Dirk Behme wrote:

> ksi at koi8.net wrote:
>> Signed-off-by: Sergey Kubushyn <ksi at koi8.net>
>> 
>> Here it is.
>> 
>> Changes:
>> 
>> - Split into separate board directories
>> - Removed changes to MTD_DEBUG (or whatever it's called)
>> - New CONFIG_CMD party line followed
>> - Some cosmetic fixes, cleanup etc.
>> - Patches against the latest U-Boot tree as of now.
>
> Many thanks!
>
>> Unfortunately it won't compile because of that BIOS emulator or what
> it
>> is...
>
> I just sent a hackish patch to be able to at least compile.
>
> With this, some comments to your recent patches:
>
> 1) As with your first set of patches, I can't get patch 2/5 and 4/5 get
> apply 
> cleanly. I get rejects needing manual resolve for everything modifying 
> already existing files. All files/patches adding new files apply
> cleanly.

That is extremely strange because the entire patch is made against
yesterday's git tree. I don't know, may be you guys have some other tree,
but I made the patch against what I pulled yesterday.

> 2) The net files don't compile because they need new style config option
>
> #if defined(CONFIG_CMD_NET) ...

OK, that's easy. I'll fix that.

> 3) Schmoogie config needs a #undef CONFIG_CMD_EEPROM instead of a
> #define

That's also easy.

> 4) With schmoogie config, schmoogie/dv_board.c fails linking because of 
> missing forceenv(). E.g. in exports.h this is clamped by #ifdef 
> CONFIG_HAS_UID. So I think misc_init_r() in all three dv_board.c need 
> anything similiar.

OK, that is also easy, I'll fix it today.

>
> I will send my updated versions of your patches for reference as answers
> to 
> the individual patch mails. No, I don't want to steal anything. I want
> to 
> help. They resolve 1) - 3), so only (4) is open. Feel free to send them
> again 
> with your Signed-off-by, to ignore them, or use them for update. You 
> mentioned that you are short of time, so hopefully we can avoid to
> invent the 
> wheel two times and reuse stuff already fixed.
>
> For me, then everything else looks okay ;) So I think resolving (4) will
> be 
> the hopefully final version then.
>
> Best regards
>
> Dirk
>

---
******************************************************************
*  KSI at home    KOI8 Net  < >  The impossible we do immediately.  *
*  Las Vegas   NV, USA   < >  Miracles require 24-hour notice.   *
******************************************************************