[U-Boot-Users] Cleanup output of MPC83xx boards

Wolfgang Denk wd at denx.de
Sun Aug 12 18:25:27 CEST 2007


Dear Kim,

I would like to suggest to clean up the output printed by most
MPC83xx boards a bit. What do you think about a patch like this one:

@@ ...
 {
        u32 msize = 0;
 
-       puts ("Initializing\n");
        msize = fixed_sdram ();
-       puts ("   DDR RAM: ");
 
        return msize;
 }

I think something like this should be applied toi the following files:

	board/sbc8349/sbc8349.c
	board/mpc832xemds/mpc832xemds.c
	board/mpc8360emds/mpc8360emds.c
	board/freescale/mpc8323erdb/mpc8323erdb.c
	board/mpc8349itx/mpc8349itx.c
	board/mpc8349emds/mpc8349emds.c
	board/mpc8313erdb/sdram.c

Also, if I understand this correctly, these  files  use  a  hardwired
memory  size.  I this correct? Do you have any plans to bring this in
line  with  the  normal  U-Boot  design  philisophy  which  uses  the
memsize() function to automatically detect and adjust for the size of
memory  really  present on a board, allowing to use the same image on
differing configurations?

Thanks, and best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Shakespeare's Law of Prototyping: (Hamlet III, iv, 156-160)
        O, throw away the worser part of it,
        And live the purer with the other half.




More information about the U-Boot mailing list