[U-Boot-Users] omap2420h4 error

[Dirk Behme]

Looking at arm-errors.tar.gz -> omap2420h4.ERR

common/libcommon.a(env_flash.o): In function `env_init':
/.automount/castor-vlab/root/home/wd/git/u-boot/work/common/env_flash.c:265: 
undefined reference to `flash_probe'
make: *** [/work/wd/tmp/u-boot-arm/u-boot] Error 1

is because in board/omap2420h4 file flash.c isn't used any more. This 
file contains flash_probe(), but it isn't compiled. If enabled for 
test, there are tons of link conflicts with cfi_flash.c.

So looks to me that omap2420h4 switch to cfi disabled flash.c (and 
didn't remove it) but missed to resolve flash_probe() call in env_flash.c.

http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=49a7581c6ced35379ec3c450bb60fe736db9d733

Proposal to fix this is to remove unused file board/omap2420h4/flash.c 
and remove calls of flash_probe()/omap2420h4 #ifdefs in env_flash.c. 
However, not sure if this is correct.

Opinions?

Cheers

Dirk