[U-Boot-Users] [PATCH] MPC5xxx: fix some compiler warnings in USB code

[Markus Klotzbücher]

Hi Martin,

Martin Krause <martin.krause at tqs.de> writes:

> Fix the following warnings:
> - usb.c:xx: warning: function declaration isn't a prototype
> - usb_ohci.c:xxx: warning: passing argument 1 of '__fswab32' makes integer
>   from pointer wihtout a cast 
>
> Signed-off-by: Martin Krause <martin.krase at tqs.de>

Thanks, will be added to Custodian repo.

> Some remarks:
>
> The patch fixes the compiler warnings, but I'm not sure, if the
> original code is correct. It seems, that in function periodic_unlink()
> the pointer ed_p is little/big endian swapped and not the content, the
> pointer is pointing to. Not sure if this was intended. Maybe some USB 
> expert (Markus?) could take a look at this?

Hmm, not sure. I'll try to take a look, but it'll take a while. Are you
experiencing a problem you suspect is caused by this?

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de