[U-Boot-Users] [PATCH] MPC5xxx: fix some compiler warnings in USB code

Martin Krause Martin.Krause at tqs.de
Fri Aug 24 09:27:57 CEST 2007


Hi Markus,

Markus Klotzbücher wrote on Thursday, August 23, 2007 6:26 PM:
> > The patch fixes the compiler warnings, but I'm not sure, if the
> > original code is correct. It seems, that in function
> > periodic_unlink() the pointer ed_p is little/big endian swapped and
> > not the content, the pointer is pointing to. Not sure if this was
> > intended. Maybe some USB expert (Markus?) could take a look at this?
> 
> Hmm, not sure. I'll try to take a look, but it'll take a while. Are
> you experiencing a problem you suspect is caused by this?

No, no problems. I only found it strange to byte-swap a pointer and
then compare it to another (unswapped) pointer. But maybe this is all 
OK for pointes included in USB data structures (because of little/big
endian conversion).

Best Regards,
Martin Krause




More information about the U-Boot mailing list