[U-Boot-Users] [PATCH] MPC5xxx: fix some compiler warnings in USB code
Wolfgang Denk
wd at denx.de
Wed Aug 29 02:11:39 CEST 2007
In message <20070821102751.5636.68943.stgit at tq-sewsrv-4.tq-net.de> you wrote:
> Fix the following warnings:
> - usb.c:xx: warning: function declaration isn't a prototype
> - usb_ohci.c:xxx: warning: passing argument 1 of '__fswab32' makes integer
> from pointer wihtout a cast
>
> Signed-off-by: Martin Krause <martin.krase at tqs.de>
Applied, thanks.
> Some remarks:
>
> The patch fixes the compiler warnings, but I'm not sure, if the
> original code is correct. It seems, that in function periodic_unlink()
> the pointer ed_p is little/big endian swapped and not the content, the
> pointer is pointing to. Not sure if this was intended. Maybe some USB
> expert (Markus?) could take a look at this?
Markus, I accepted this patch to get rid of the warnings for the
2.3.0-rc1 version. Could you please check the code again it if needs
to be changed as Martin suggests?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Gods don't like people not doing much work. People who aren't busy
all the time might start to _think_. - Terry Pratchett, _Small Gods_
More information about the U-Boot
mailing list