[U-Boot-Users] [PATCH] ARM: add support of CONFIG_LAST_STAGE_INIT for arm

[Wolfgang Denk]

In message <1197193806-26116-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> 
> diff --git a/lib_arm/board.c b/lib_arm/board.c
> index 6f35aa0..0eadc3a 100644
> --- a/lib_arm/board.c
> +++ b/lib_arm/board.c
> @@ -431,6 +431,14 @@ extern void dm644x_eth_set_mac_addr (const u_int8_t *addr);
>  #endif
>  	eth_initialize(gd->bd);
>  #endif
> +#ifdef CONFIG_LAST_STAGE_INIT
> +	/*
> +	 * Some parts can be only initialized if all others (like
> +	 * Interrupts) are up and running (i.e. the PC-style ISA
> +	 * keyboard).
> +	 */
> +	last_stage_init ();
> +#endif
>  	/* main_loop() can return to retry autoboot, if so just run it again. */
>  	for (;;) {
>  		main_loop ();
> -- 

Please, not yet another such thing.

Is there any specific reason why you cannot use any of the existing
entry points, like for example board_late_init() ?

Also, if this is really, really necessary (which I seriously doubt)
please use a weak function declaration instead of an #ifdef.

We want to get rid of this #ifdef mess...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Eureka!                                                 -- Archimedes