[U-Boot-Users] [PATCH] Add S3C2410 MMC/SD support

Stefan Roese sr at denx.de
Sat Feb 17 08:20:22 CET 2007


On Saturday 17 February 2007 03:31, Grant Likely wrote:
> Here are some comments after a quick review.

And some more...

<snip>
> > +static u_int32_t *
> > +/****************************************************/
> > +mmc_cmd(ushort cmd, ulong arg, ushort flags)
> > +/****************************************************/
>
> I'm not so fond of the style putting a comment line between the
> function name and the return type.  I think they should be together.
> What does everyone else think?

ACK. Very confusing this way.

Best regards,
Stefan




More information about the U-Boot mailing list