[U-Boot-Users] [PATCH] Add S3C2410 MMC/SD support

Harald Welte laforge at openmoko.org
Sat Feb 17 11:23:03 CET 2007


On Sat, Feb 17, 2007 at 08:20:22AM +0100, Stefan Roese wrote:
> <snip>
> > > +static u_int32_t *
> > > +/****************************************************/
> > > +mmc_cmd(ushort cmd, ulong arg, ushort flags)
> > > +/****************************************************/
> >
> > I'm not so fond of the style putting a comment line between the
> > function name and the return type.  I think they should be together.
> > What does everyone else think?
> 
> ACK. Very confusing this way.

Ok.  This is actually a remnescent from the original mmc code that I
used as an example/basis.  I'll remove it from my patch, thanks.
-- 
- Harald Welte <laforge at openmoko.org>          	        http://openmoko.org/
============================================================================
Software for the world's first truly open Free Software mobile phone




More information about the U-Boot mailing list