[U-Boot-Users] An obvious bug in cpu/s3c44b0/serial.c

Rui.Zhou at nokia.com Rui.Zhou at nokia.com
Wed Jan 24 06:10:56 CET 2007


Hi there

there is an obvious bug in cpu/s3c44b0/serial.c (1.1.4)
Now I am unable to download the latest version to check(1.2.0?)
Is it corrected?

********************************************************

void serial_setbrg (void)
	DECLARE_GLOBAL_DATA_PTR;

	u32 divisor = 0;

	/* get correct divisor */
	switch(gd->baudrate) {

	case 1200:
#if CONFIG_S3C44B0_CLOCK_SPEED==66
		divisor = 3124;
#elif CONFIG_S3C44B0_CLOCK_SPEED==75
		divisor = 3905;
#else
# error CONFIG_S3C44B0_CLOCK_SPEED undefined
#endif
		break;


.......


	case 38400:
#if CONFIG_S3C44B0_CLOCK_SPEED==66
		divisor = 97;
#elif CONFIG_S3C44B0_CLOCK_SPEED==75
		divisor = 121;
#else
# error CONFIG_S3C44B0_CLOCK_SPEED undefined
#endif	/* break; */


Why it is commented? 

	case 57600:
#if CONFIG_S3C44B0_CLOCK_SPEED==66
		divisor = 64;
#elif CONFIG_S3C44B0_CLOCK_SPEED==75
		divisor = 80;
#else
# error CONFIG_S3C44B0_CLOCK_SPEED undefined
#endif	/* break; */





Best Regards 
ZhouRui




-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20070124/89f304f3/attachment.htm 


More information about the U-Boot mailing list