[U-Boot-Users] [PATCH] Add support for the MPC8349E-mITX-GP

[Kumar Gala]

On Jan 25, 2007, at 10:41 PM, Timur Tabi wrote:

> Kim Phillips wrote:
>> On Wed, 17 Jan 2007 09:09:45 -0600
>> timur at freescale.com wrote:
>>
>>> From: Timur Tabi <timur at freescale.com>
>>>
>>> Add support for the MPC8349E-mITX-GP, a stripped-down version of the
>>> MPC8349E-mITX.
>>>
>>> Signed-off-by: Timur Tabi <timur at freescale.com>
>>> ---
>>>  MAINTAINERS                   |    1 +
>>>  Makefile                      |   16 ++-
>>>  board/mpc8349itx/config.mk    |    6 +-
>>>  board/mpc8349itx/mpc8349itx.c |  105 ++--------
>>>  include/configs/MPC8349ITX.h  |  463 +++++++++++++++ 
>>> +-------------------------
>>>  include/mpc83xx.h             |   41 ++++
>>
>> Timur, this looks good except new boards should at least have  
>> their own config file;
>> I have a problem with multiple ifdef CONFIG_MPC8349ITX checks in  
>> MPC8349ITX.h.
>
> The ITX and the ITX-GP are basically the same board, except the ITX  
> has
> a few extra peripherals.  It doesn't make sense to have separate  
> config
> files.
>
> As for the ifdefs, there are only three - one that defines the CF card
> that only the ITX has, one for the flash sizes, and another for the
> command prompt.  I could technically move these into the Makefile,
> eliminating any ifdefs from the header file.  Do you want me to do  
> that?

Since they are different physical boards they should have different  
<config>.h, that rule's been pretty standard in u-boot.

- k