[U-Boot-Users] [PATCH 2/3] Added USB PCI-OHCI chips support, interrupt pipe support and usb event poll support.

Robert Delien robert.delien at nxp.com
Tue Jul 3 10:25:43 CEST 2007


Hello Zhang,

> This patch added USB PCI-OHCI chips support, interrupt pipe support
> and usb event poll support. For supporting the USB interrupt pipe,
> the globe urb_priv is moved to purb in ed struct. Now, we can
> process several urbs at one time. The interrupt pipe support codes
> are ported from Linux kernel 2.4.

Two questions/remarks:
1. Why are you defining two macros, called 'readl' and 'writel', while both
of these are available from asm/io.h on all architectures?
2. In 'usb_lowlevel_int' the register base address isn't translated from
PCI address space to processor address space.

With kind regards,

      Robert.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20070703/a6bd59da/attachment.htm 


More information about the U-Boot mailing list