[U-Boot-Users] [PATCH 2/3] Added USB PCI-OHCI chips support, interrupt pipe support and usb event poll support.

Zhang Wei-r63237 Wei.Zhang at freescale.com
Tue Jul 3 11:01:57 CEST 2007


Hi, Robert,

Thanks!

> From: Robert Delien [mailto:robert.delien at nxp.com] 
> Hello Zhang,
> Two questions/remarks:
> 1. Why are you defining two macros, called 'readl' and 'writel', while
both of these are available from asm/io.h on all architectures?

Yes, but here they're special macros for USB register access. You can
refer to the newest usb-git tree of Markus.

> 2. In 'usb_lowlevel_int' the register base address isn't translated
from PCI address space to processor address space.

Does current codes not run well on your system? It's in U-boot now. The
address in the PCI bar is processor address.

Cheers!
Wei.





More information about the U-Boot mailing list