[U-Boot-Users] [PATCH 0/3]Patchset for Ati bios emulator and Ati frambuffer driver

[Jin Zhengxiong-R64188]

Hi, Wolfgang,

Thanks for your feedback, Please see my inline comments.

Best Regards,
Jason

> -----Original Message-----
> From: wd at denx.de [mailto:wd at denx.de] 
> Sent: Thursday, July 05, 2007 5:54 PM
> To: Jin Zhengxiong-R64188
> Cc: sr at denx.de; u-boot-users at lists.sourceforge.net; Loeliger 
> Jon-LOELIGER
> Subject: Re: [U-Boot-Users] [PATCH 0/3]Patchset for Ati bios 
> emulator and Ati frambuffer driver 
> 
> In message 
> <11836285951474-git-send-email-Jason.jin at freescale.com> you wrote:
> > 
> > This patchset add Ati bios emulator and Ati video card framebuffer 
> > driver to u-boot. The bios emulator and the framebuffer 
> driver work for Ati PCI and PCIE video card. We tested the 
> patchset on 9200 PCI card, X300, X700 and X800 PCIE card in 
> u-boot on M PC8641HPCN board. After the video card bios 
> finish runnig in the bios emulator, We can use the Ati 
> framebuffer driver in u-boot, we can also use the radeon base 
> driver in kernel directly for those Ati video card.
> 
> Please restrict your line length to < 80 characters or so 
> when posting, and make sure to read the patch submission 
> rules - see http://www.denx.de/wiki/UBoot/Patches

Each of the two patch is a logical part and I think they should not be
split into separate part, I'll try to provide a URL for the two patches.

> Ati bios emulator - Why do we need another emulator? Is the 
> one we have in board/MAI/bios_emulator/ not sufficient for 
> your purposes?

Yes, I found there's a bios_emulator in board/MAI/bios_emulator, but
it's board specific and I can not use it directly, actually both of the
emulator come from Scitech, I tried to make it clean and clear during my
porting. On the other side, I tried to compile it for the MAI board but
compile failed.  
If other board want to use the bios emulator, I suggest moving it out
from the board and make it clean.