[U-Boot-Users] [PATCH 0/3]Patchset for Ati bios emulator and Ati frambuffer driver

Wolfgang Denk wd at denx.de
Thu Jul 5 20:55:56 CEST 2007


Hello,

in message <CC27DED0F8F39E48A7E75FD768688B7A3E97A2 at zch01exm27.fsl.freescale.net> you wrote:
> 
> > Please restrict your line length to < 80 characters or so 
> > when posting, and make sure to read the patch submission 
> > rules - see http://www.denx.de/wiki/UBoot/Patches
> 
> Each of the two patch is a logical part and I think they should not be
> split into separate part, I'll try to provide a URL for the two patches.

Well, ok, but actually this has nothing to do with the line length of
your postings on this mailing list, right?

> > Ati bios emulator - Why do we need another emulator? Is the 
> > one we have in board/MAI/bios_emulator/ not sufficient for 
> > your purposes?
> 
> Yes, I found there's a bios_emulator in board/MAI/bios_emulator, but
> it's board specific and I can not use it directly, actually both of the
> emulator come from Scitech, I tried to make it clean and clear during my
> porting. On the other side, I tried to compile it for the MAI board but
> compile failed.  
> If other board want to use the bios emulator, I suggest moving it out
> from the board and make it clean.

Can you please do that, then? It's the logic consequence.  I  do  not
want  to  add  another  800  kB of code for a feature that is already
present. If cleanup and.or generalization is  needed,  then  this  is
what  has  to  be done. If you find that your solution is better than
the existing one, you have to prove that and replace the old one.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The only thing necessary for the triumph of evil is for good  men  to
do nothing.                                            - Edmund Burke




More information about the U-Boot mailing list