[U-Boot-Users] [PATCH] pciauto_setup_device bars_num fix

Shinya Kuribayashi shinya.kuribayashi at necel.com
Thu Jul 26 03:27:12 CEST 2007


Ed Swarthout wrote:
> Passing bars_num=0 to pciauto_setup_device should assign no bars.
> 
> Signed-off-by: Ed Swarthout <Ed.Swarthout at freescale.com>

Indeed. This patch works fine on our MIPS target.

Acked-by: Shinya Kuribayashi <shinya.kuribayashi at necel.com>

> ---
>  drivers/pci_auto.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pci_auto.c b/drivers/pci_auto.c
> index a3c609b..2378553 100644
> --- a/drivers/pci_auto.c
> +++ b/drivers/pci_auto.c
> @@ -94,7 +94,7 @@ void pciauto_setup_device(struct pci_controller *hose,
>  	pci_hose_read_config_dword(hose, dev, PCI_COMMAND, &cmdstat);
>  	cmdstat = (cmdstat & ~(PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) | PCI_COMMAND_MASTER;
>  
> -	for (bar = PCI_BASE_ADDRESS_0; bar <= PCI_BASE_ADDRESS_0 + (bars_num*4); bar += 4) {
> +	for (bar = PCI_BASE_ADDRESS_0; bar < PCI_BASE_ADDRESS_0 + (bars_num*4); bar += 4) {
>  		/* Tickle the BAR and get the response */
>  		pci_hose_write_config_dword(hose, dev, bar, 0xffffffff);
>  		pci_hose_read_config_dword(hose, dev, bar, &bar_response);




More information about the U-Boot mailing list