[U-Boot-Users] at45.c repeated / ditto with flash.c (arm920t board)

Nelson Castillo nelsoneci at gmail.com
Mon Jun 4 11:22:05 CEST 2007


Hi,

I'm new to the list. Is it OK to send patches here?
I hope to receive your advise on how to send patches to
U-boot.

I'm creating a patch against git/HEAD and I noticed
that after the patch we get a file (at45.c) 3 times.

* Is it ok I send a patch to factor it?

* What example (a file that has been factored before) should I follow?

There is one difference between cmc_pu2/at91rm9200dk with a
cast that seems to be there just to avoid a warning

$ find . -name at45.c
./board/cmc_pu2/at45.c
./board/at91rm9200dk/at45.c
./board/ecb_at91/at45.c

The patch also duplicates the file

  board/at91rm9200dk/flash.c

Can it be factored? How should it be done?

Regards,
Nelson.-

[1] http://www.emqbit.com/tmp/ecb_at91_support.diff.bz2

-- 
http://arhuaco.org
http://emQbit.com




More information about the U-Boot mailing list