[U-Boot-Users] at45.c repeated / ditto with flash.c (arm920t board)

Wolfgang Denk wd at denx.de
Mon Jun 4 13:04:15 CEST 2007


In message <2accc2ff0706040222g47a35bbdxe6151530114d1dd6 at mail.gmail.com> you wrote:
> 
> I'm new to the list. Is it OK to send patches here?

Yes, it is.

> I hope to receive your advise on how to send patches to
> U-boot.

Please see http://www.denx.de/wiki/UBoot/Patches

> I'm creating a patch against git/HEAD and I noticed
> that after the patch we get a file (at45.c) 3 times.

Please make sure to use the current code base, in this case the
u-boot-arm custodian repository; see
http://www.denx.de/wiki/UBoot/Custodians

> * Is it ok I send a patch to factor it?

If it makes sense, of course.

> The patch also duplicates the file
> 
>   board/at91rm9200dk/flash.c
> 
> Can it be factored? How should it be done?

Umm... cannot you use the CFI driver instead?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You're dead, Jim.
	-- McCoy, "The Tholian Web", stardate unknown




More information about the U-Boot mailing list