[U-Boot-Users] ROMFS

Wolfgang Denk wd at denx.de
Sat Jun 23 14:34:16 CEST 2007


Hello,

in message <2563.4065-19092-1374891071-1182588014 at seznam.cz> you wrote:
> 
> >Then please also remove the remaining ones now (trailing white space
> >in common/cmd_jffs2.c) and resubmit again.
> 
> I checked all files on trailing white space.  I don't see them.

I know. That's the problem with white space - you don't see it.
Printing characters are better visible ;-)

> [microblaze at monstr u-boot]$ patch -p1 < ../romfs3.patch
> patching file Makefile
> patching file common/cmd_jffs2.c
> patching file fs/Makefile
> patching file fs/romfs/Makefile
> patching file fs/romfs/romfs.c
> [microblaze at monstr u-boot]$ cat Makefile | grep " $"
> [microblaze at monstr u-boot]$ cat common/cmd_jffs2.c | grep " $"
> [microblaze at monstr u-boot]$ cat fs/Makefile | grep " $"
> [microblaze at monstr u-boot]$ cat fs/romfs/Makefile | grep " $"
> [microblaze at monstr u-boot]$ cat fs/romfs/romfs.c | grep " $"

This gives you 5 UUOCA in a row, whichis kind of  a  record,  but  it
does  not  help  much - for example, you don't find any trailing TABs
that way.

> ...
> diff --git a/common/cmd_jffs2.c b/common/cmd_jffs2.c
> index 7fd1fa3..6da6470 100644
> ...
> @@ -1961,13 +1975,18 @@ int do_jffs2_fsinfo(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
>  	if ((part = jffs2_part_info(current_dev, current_partnum))){
>  
>  		/* check partition type for cramfs */
> -		fsname = (cramfs_check(part) ? "CRAMFS" : "JFFS2");
> -		printf("### filesystem type is %s\n", fsname);
> +		puts("### filesystem type is ");
>  
>  		if (cramfs_check(part)) {
> +			puts("CRAMFS\n");
>  			ret = cramfs_info (part);
> +			

vi's "l" command shows this line as "+^I^I^I$", i. e. 3 trailing TABs.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You cannot propel yourself forward by patting yourself on the back.




More information about the U-Boot mailing list