[U-Boot-Users] [PATCH] net - Support ping reply when processing net-loop

[Ben Warren]

Ed,

This looks like a useful debug tool.  Please fix a little nit.  In the
meantime I'm going to play around with it a bit.

On Mon, 2007-03-05 at 23:33 -0600, Ed Swarthout wrote:
<SNIP>
> +
> +			case ICMP_ECHO_REQUEST:
> +			{
> +				int rlen = ETHER_HDR_SIZE + len;
> +				int i;
These variables aren't necessary.  'i' isn't even used.  Please ditch
them along with the braces.  You can calcalate the length in the two
places that it's referenced.

regards,
Ben