[U-Boot-Users] [PATCH 1/3] Initial OneNAND support

[Wolfgang Denk]

Dear Kyungmin Park,

in message <001201c76623$2e7b9cd0$c7a3580a at swcenter.sec.samsung.co.kr> you wrote:
> 
> This patch supports OneNAND device on U-Boot.
> The most codes are based on OneNAND MTD in kernel.

Your patches have a few cosing style issues (indentation not by TAB's,
trailing white space). Please clean up and resubmet; see also
http://www.denx.de/wiki/UBoot/CodingStyle

Also, please restrict your line length no around 70 characters or so.

And can you please add a GPL license header to onenand/onenand_bbt.c,
include/linux/mtd/bbm.h

> For better performance I added 32-bytes aligned memcpy32. 
> Pleae check it.

Did you measure how much of performance  this  gains?  Is  it  really
worth the effort? In any case, the file needs a GPL license header.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It's not an optical illusion, it just looks like one.   -- Phil White